Apply item-level discount before tax calculation - #289
Open
Marvin-Magmodules wants to merge 1 commit into
Open
Conversation
Channable sends per-product discount fields but these were ignored. Discounts were only applied at order level after tax was already calculated, causing tax to be computed on the undiscounted price. Now subtracts item discount from OriginalCustomPrice so Magento calculates tax on the correct (discounted) amount. Falls back to order-level discount when no item discounts are present. Adds E2E tests for item-level discount tax calculation. Ref: channable/magento-plugin#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discountfields but these were ignoredOriginalCustomPriceso Magento calculates tax on the correct (discounted) amountChanges
Service/Order/Items/Add.php— subtractitem['discount']from price before settingOriginalCustomPriceService/Order/Import.php— skip order-level discount when item-level discounts exist (prevents double discount)